Fix a bug where arduino would crash on incorrectly sized i2c payload

README.md

@@ -0,0 +1,7 @@
+# To install on robot
+
+```
+git clone <url>
+cd lewis-crawler/crawler_software/raspberry_pi
+make install?
+```

crawler_software/arduino/crawler_slave/crawler_slave.ino

@@ -10,27 +10,28 @@
 // This servo is used to wipe and clean the camera lens
 Servo windowWiperServo;
 
-// This is a variable capable of storing up to 4 items
-char instruction[32] = "";
-
-// Values for the id, and raw value of an instruction
-char * id;
-char * raw_value;
+// Variables populated over i2c from master
+int id;
+int val;
 
 void setup() {
+  // For debugging
+  //Serial.begin(115200);
+  
   // Attach the wiper servo to pin 9
   windowWiperServo.attach(9);
 
-  // This is only useful for debugging
-  //Serial.begin(9600);
-
   // This is the address the pi will speak to us at
   Wire.begin(0x4);
   
   // Call receiveEvent when data received                
   Wire.onReceive(receiveEvent);
 
-  //Serial.println("Finished Setup.");  
+  // Setup LED
+  pinMode(LED_BUILTIN, OUTPUT);
+  digitalWrite(LED_BUILTIN, LOW);
+
+  //Serial.println("Started");
 }
 
 // Just loop to keep the running code alive, and wait for events to happen.
@@ -40,27 +41,23 @@ void loop() {
 
 // This method runs when we receive a message
 void receiveEvent(int n) {
+  Wire.read(); // Remove smbus trash
+  if (true) { // Dont do anything if this is not true
+    id  = Wire.read(); // ID of the servo/device to access
+    val = Wire.read(); // Value to assign
 
-  for (int i = 0; i < n; i++) {
-    instruction[i] = Wire.read();
-    instruction[i + 1] = '\0'; //add null after ea. char
+    //Serial.println(id);
+    //Serial.println(val);
+  
+    switch(id) {
+      case 1:
+        windowWiperServo.write(val);
+        break;
+    }
   }
 
-  //RPi first byte is cmd byte so shift everything to the left 1 pos so temp contains our string
-  for (int i = 0; i < n; ++i)
-    instruction[i] = instruction[i + 1];
-
-  id = strtok (instruction, "-");
-  raw_value = strtok (NULL, "-");
-
-  int value = atoi(raw_value);
-
-  //Serial.println(id);
-  //Serial.println(value);
-
-  // Switch statements dont work on char *
-  if (strcmp(id,"WIPE") == 0) // if id, and WIPE cancel out
-  {
-    windowWiperServo.write(value);
+  // Prevents a bug where if bytes are left in buffer, arduino crashes.
+  while (Wire.available()) {
+    Wire.read();
   }
 }

crawler_software/raspberry_pi/crawler.service

@@ -0,0 +1,11 @@
+[Unit]
+Description=Crawler service overseer, manages running main crawler software
+After=multi-user.target
+
+[Service]
+Type=simple
+Restart=always
+ExecStart=/usr/bin/python /srv/crawler/crawler.py
+
+[Install]
+WantedBy=multi-user.target

crawler_software/raspberry_pi/requirements.txt

@@ -1,2 +1,2 @@
 PySSTV
-picamera
+picamera

crawler_software/raspberry_pi/tests/discordbot.py

@@ -5,18 +5,30 @@ from gps import *
 from smbus import SMBus
 import time
 
-addr = 0x8 # bus address
+addr = 0x4 # bus address
 bus = SMBus(1) # indicates /dev/ic2-1
 
 numb = 1
 
+def writeData(value):
+    byteValue = StringToBytes(value)    
+    bus.write_i2c_block_data(addr,0x00,byteValue) #first byte is 0=command byte.. just is.
+    return -1
+
+
+def StringToBytes(val):
+        retVal = []
+        for c in val:
+                retVal.append(ord(c))
+        return retVal
+
 try:
     for _x in range (0, 2):
-            for i in range(70, 130):
-                    bus.write_byte(addr, i)
+            for i in range(78, 130):
+                    writeData("WIPE-" + str(i))
                     time.sleep(0.02)
-            for i in range(130, 70, -1):
-                    bus.write_byte(addr, i)
+            for i in range(130, 78, -1):
+                    writeData("WIPE-" + str(i))
                     time.sleep(0.02)
 except OSError:
     print("Could not speak to ardujmemo")

crawler_software/raspberry_pi/tests/stack_overflow.py

@@ -0,0 +1,20 @@
+import smbus
+import time
+import struct
+
+# for RPI version 1, use bus = smbus.SMBus(0)
+bus = smbus.SMBus(1)
+
+# This is the address we setup in the Arduino Program
+address = 0x04
+
+try:
+    for _x in range (0, 2):
+            for i in range(78, 130):
+                    bus.write_i2c_block_data(address, 0, [1, i])
+                    time.sleep(0.02)
+            for i in range(130, 78, -1):
+                    bus.write_i2c_block_data(address, 0, [1, i])
+                    time.sleep(0.02)
+except OSError:
+    print("Could not speak to ardujmemo")